From 94355e5201d090fb8bf2c73787c858e78c91fc80 Mon Sep 17 00:00:00 2001 From: Elias Naur Date: Tue, 26 Nov 2024 09:27:00 +0000 Subject: [PATCH] internal/vk: remove methods on C types, for Go 1.24 compatibility Go 1.24 no longer allows methods on C types (golang.org/issue/60725). Signed-off-by: Elias Naur --- app/vulkan.go | 2 +- gpu/internal/vulkan/vulkan.go | 4 ++-- internal/vk/vulkan.go | 12 ++++++------ 3 files changed, 9 insertions(+), 9 deletions(-) diff --git a/app/vulkan.go b/app/vulkan.go index db7d1492..f6550947 100644 --- a/app/vulkan.go +++ b/app/vulkan.go @@ -175,7 +175,7 @@ func (c *vkContext) refresh(surf vk.Surface, width, height int) error { if err != nil { return err } - minExt, maxExt := caps.MinExtent(), caps.MaxExtent() + minExt, maxExt := vk.SurfaceCapabilitiesMinExtent(caps), vk.SurfaceCapabilitiesMaxExtent(caps) if width < minExt.X || maxExt.X < width || height < minExt.Y || maxExt.Y < height { return errOutOfDate } diff --git a/gpu/internal/vulkan/vulkan.go b/gpu/internal/vulkan/vulkan.go index 9ae0bc69..4c39cb5f 100644 --- a/gpu/internal/vulkan/vulkan.go +++ b/gpu/internal/vulkan/vulkan.go @@ -862,8 +862,8 @@ func (b *Backend) BindUniforms(buffer driver.Buffer) { buf := buffer.(*Buffer) cmdBuf := b.currentCmdBuf() for _, s := range b.pipe.pushRanges { - off := s.Offset() - vk.CmdPushConstants(cmdBuf, b.pipe.desc.layout, s.StageFlags(), off, buf.store[off:off+s.Size()]) + off := vk.PushConstantRangeOffset(s) + vk.CmdPushConstants(cmdBuf, b.pipe.desc.layout, vk.PushConstantRangeStageFlags(s), off, buf.store[off:off+vk.PushConstantRangeSize(s)]) } } diff --git a/internal/vk/vulkan.go b/internal/vk/vulkan.go index 9d63c84a..63e5e3aa 100644 --- a/internal/vk/vulkan.go +++ b/internal/vk/vulkan.go @@ -1893,27 +1893,27 @@ func BuildWriteDescriptorSetBuffer(set DescriptorSet, binding int, typ Descripto } } -func (r PushConstantRange) StageFlags() ShaderStageFlags { +func PushConstantRangeStageFlags(r PushConstantRange) ShaderStageFlags { return r.stageFlags } -func (r PushConstantRange) Offset() int { +func PushConstantRangeOffset(r PushConstantRange) int { return int(r.offset) } -func (r PushConstantRange) Size() int { +func PushConstantRangeSize(r PushConstantRange) int { return int(r.size) } -func (p QueueFamilyProperties) Flags() QueueFlags { +func QueueFamilyPropertiesFlags(p QueueFamilyProperties) QueueFlags { return p.queueFlags } -func (c SurfaceCapabilities) MinExtent() image.Point { +func SurfaceCapabilitiesMinExtent(c SurfaceCapabilities) image.Point { return image.Pt(int(c.minImageExtent.width), int(c.minImageExtent.height)) } -func (c SurfaceCapabilities) MaxExtent() image.Point { +func SurfaceCapabilitiesMaxExtent(c SurfaceCapabilities) image.Point { return image.Pt(int(c.maxImageExtent.width), int(c.maxImageExtent.height)) }