From b9846b48b858490a95f5dd4dc22860693b4cbf5d Mon Sep 17 00:00:00 2001 From: Inkeliz Date: Tue, 1 Dec 2020 06:26:44 +0000 Subject: [PATCH] app/internal/glimpl: [wasm] remove slow getError calls The removal of getError significantly improves performance on js/wasm: Opera 72 (w/ AMD Ryzen 3900X): ~12.29ms per frame to ~8.09ms; Chrome 87 (w/ Snapdragon 435): ~156.34ms per frame to ~94.31ms; Signed-off-by: Inkeliz --- app/internal/glimpl/gl_js.go | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/app/internal/glimpl/gl_js.go b/app/internal/glimpl/gl_js.go index e4291d03..0fa71160 100644 --- a/app/internal/glimpl/gl_js.go +++ b/app/internal/glimpl/gl_js.go @@ -185,7 +185,8 @@ func (f *Functions) FramebufferTexture2D(target, attachment, texTarget gl.Enum, f.Ctx.Call("framebufferTexture2D", int(target), int(attachment), int(texTarget), js.Value(t), level) } func (f *Functions) GetError() gl.Enum { - return gl.Enum(f.Ctx.Call("getError").Int()) + // Avoid slow getError calls. See gio#179. + return 0 } func (f *Functions) GetRenderbufferParameteri(target, pname gl.Enum) int { return paramVal(f.Ctx.Call("getRenderbufferParameteri", int(pname)))