joejulian/gio
1
0
Fork 1
mirror of https://git.sr.ht/~eliasnaur/gio synced 2026-07-08 02:45:38 +00:00
Code Issues Packages Projects Releases Wiki Activity

text,widget: remove ineffective assignments

Browse Source 
Signed-off-by: Serhat Sevki Dincer <jfcgauss@gmail.com>
This commit is contained in:
Serhat Sevki Dincer
2023-02-23 22:41:03 +11:00
committed by Elias Naur
parent 39b1158410
commit 35a8231963
3 changed files with 5 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
text/gotext_test.go
+1 -1
View File
@@ -258,7 +258,7 @@ func makeTestText(shaper *shaperImpl, primaryDir system.TextDirection, fontSize,
} }
simpleText := shaper.shapeAndWrapText(shaper.orderer.sortedFacesForStyle(Font{}), Parameters{PxPerEm: fixed.I(fontSize)}, lineWidth, locale, []rune(simpleSource)) simpleText := shaper.shapeAndWrapText(shaper.orderer.sortedFacesForStyle(Font{}), Parameters{PxPerEm: fixed.I(fontSize)}, lineWidth, locale, []rune(simpleSource))
complexText := shaper.shapeAndWrapText(shaper.orderer.sortedFacesForStyle(Font{}), Parameters{PxPerEm: fixed.I(fontSize)}, lineWidth, locale, []rune(complexSource)) complexText := shaper.shapeAndWrapText(shaper.orderer.sortedFacesForStyle(Font{}), Parameters{PxPerEm: fixed.I(fontSize)}, lineWidth, locale, []rune(complexSource))
shaper = testShaper(rtlFace, ltrFace) testShaper(rtlFace, ltrFace)
return simpleText, complexText return simpleText, complexText
} }
widget/editor_test.go
+4 -4
View File
@@ -117,12 +117,12 @@ func TestEditorReadOnly(t *testing.T) {
if cStart != cEnd { if cStart != cEnd {
t.Errorf("unexpected initial caret positions") t.Errorf("unexpected initial caret positions")
} }
dims := e.Layout(gtx, cache, font, fontSize, nil) e.Layout(gtx, cache, font, fontSize, nil)
// Select everything. // Select everything.
gtx.Ops.Reset() gtx.Ops.Reset()
gtx.Queue = &testQueue{events: []event.Event{key.Event{Name: "A", Modifiers: key.ModShortcut}}} gtx.Queue = &testQueue{events: []event.Event{key.Event{Name: "A", Modifiers: key.ModShortcut}}}
dims = e.Layout(gtx, cache, font, fontSize, nil) e.Layout(gtx, cache, font, fontSize, nil)
textContent := e.Text() textContent := e.Text()
cStart2, cEnd2 := e.Selection() cStart2, cEnd2 := e.Selection()
if cStart2 > cEnd2 { if cStart2 > cEnd2 {
@@ -138,7 +138,7 @@ func TestEditorReadOnly(t *testing.T) {
// Type some new characters. // Type some new characters.
gtx.Ops.Reset() gtx.Ops.Reset()
gtx.Queue = &testQueue{events: []event.Event{key.EditEvent{Range: key.Range{Start: cStart2, End: cEnd2}, Text: "something else"}}} gtx.Queue = &testQueue{events: []event.Event{key.EditEvent{Range: key.Range{Start: cStart2, End: cEnd2}, Text: "something else"}}}
dims = e.Layout(gtx, cache, font, fontSize, nil) e.Layout(gtx, cache, font, fontSize, nil)
textContent2 := e.Text() textContent2 := e.Text()
if textContent2 != textContent { if textContent2 != textContent {
t.Errorf("readonly editor modified by key.EditEvent") t.Errorf("readonly editor modified by key.EditEvent")
@@ -147,7 +147,7 @@ func TestEditorReadOnly(t *testing.T) {
// Try to delete selection. // Try to delete selection.
gtx.Ops.Reset() gtx.Ops.Reset()
gtx.Queue = &testQueue{events: []event.Event{key.Event{Name: key.NameDeleteBackward}}} gtx.Queue = &testQueue{events: []event.Event{key.Event{Name: key.NameDeleteBackward}}}
dims = e.Layout(gtx, cache, font, fontSize, nil) dims := e.Layout(gtx, cache, font, fontSize, nil)
textContent2 = e.Text() textContent2 = e.Text()
if textContent2 != textContent { if textContent2 != textContent {
t.Errorf("readonly editor modified by delete key.Event") t.Errorf("readonly editor modified by delete key.Event")
widget/selectable.go
-1
View File
@@ -45,7 +45,6 @@ func (s stringSource) ReadAt(b []byte, offset int64) (int, error) {
// ReplaceRunes is unimplemented, as a stringSource is immutable. // ReplaceRunes is unimplemented, as a stringSource is immutable.
func (s stringSource) ReplaceRunes(byteOffset, runeCount int64, str string) { func (s stringSource) ReplaceRunes(byteOffset, runeCount int64, str string) {
return
} }
// Selectable holds text selection state. // Selectable holds text selection state.