app: [macOS] add missing autoreleasepools

Their absense didn't make a practical difference so far, but we're about
to refactor the macOS event processing loop where the pools do matter.

Signed-off-by: Elias Naur <mail@eliasnaur.com>

app/os_macos.go

@@ -62,142 +62,197 @@ static CFTypeRef readClipboard(void) {
 }
 
 static CGFloat viewHeight(CFTypeRef viewRef) {
+	@autoreleasepool {
 		NSView *view = (__bridge NSView *)viewRef;
 		return [view bounds].size.height;
 	}
+}
 
 static CGFloat viewWidth(CFTypeRef viewRef) {
+	@autoreleasepool {
 		NSView *view = (__bridge NSView *)viewRef;
 		return [view bounds].size.width;
 	}
+}
 
 static CGFloat getScreenBackingScale(void) {
+	@autoreleasepool {
 		return [NSScreen.mainScreen backingScaleFactor];
 	}
+}
 
 static CGFloat getViewBackingScale(CFTypeRef viewRef) {
+	@autoreleasepool {
 		NSView *view = (__bridge NSView *)viewRef;
 		return [view.window backingScaleFactor];
 	}
+}
 
 static void setNeedsDisplay(CFTypeRef viewRef) {
+	@autoreleasepool {
 		NSView *view = (__bridge NSView *)viewRef;
 		[view setNeedsDisplay:YES];
 	}
+}
 
 static NSPoint cascadeTopLeftFromPoint(CFTypeRef windowRef, NSPoint topLeft) {
+	@autoreleasepool {
 		NSWindow *window = (__bridge NSWindow *)windowRef;
 		return [window cascadeTopLeftFromPoint:topLeft];
 	}
+}
 
 static void makeKeyAndOrderFront(CFTypeRef windowRef) {
+	@autoreleasepool {
 		NSWindow *window = (__bridge NSWindow *)windowRef;
 		[window makeKeyAndOrderFront:nil];
 	}
+}
 
 static void toggleFullScreen(CFTypeRef windowRef) {
+	@autoreleasepool {
 		NSWindow *window = (__bridge NSWindow *)windowRef;
 		[window toggleFullScreen:nil];
 	}
+}
 
 static NSWindowStyleMask getWindowStyleMask(CFTypeRef windowRef) {
+	@autoreleasepool {
 		NSWindow *window = (__bridge NSWindow *)windowRef;
 		return [window styleMask];
 	}
+}
 
 static void setWindowStyleMask(CFTypeRef windowRef, NSWindowStyleMask mask) {
+	@autoreleasepool {
 		NSWindow *window = (__bridge NSWindow *)windowRef;
 		window.styleMask = mask;
 	}
+}
 
 static void setWindowTitleVisibility(CFTypeRef windowRef, NSWindowTitleVisibility state) {
+	@autoreleasepool {
 		NSWindow *window = (__bridge NSWindow *)windowRef;
 		window.titleVisibility = state;
 	}
+}
 
 static void setWindowTitlebarAppearsTransparent(CFTypeRef windowRef, int transparent) {
+	@autoreleasepool {
 		NSWindow *window = (__bridge NSWindow *)windowRef;
 		window.titlebarAppearsTransparent = (BOOL)transparent;
 	}
+}
 
 static void setWindowStandardButtonHidden(CFTypeRef windowRef, NSWindowButton btn, int hide) {
+	@autoreleasepool {
 		NSWindow *window = (__bridge NSWindow *)windowRef;
 		[window standardWindowButton:btn].hidden = (BOOL)hide;
 	}
+}
 
 static void performWindowDragWithEvent(CFTypeRef windowRef, CFTypeRef evt) {
+	@autoreleasepool {
 		NSWindow *window = (__bridge NSWindow *)windowRef;
 		[window performWindowDragWithEvent:(__bridge NSEvent*)evt];
 	}
+}
 
 static void closeWindow(CFTypeRef windowRef) {
+	@autoreleasepool {
 		NSWindow* window = (__bridge NSWindow *)windowRef;
 		[window performClose:nil];
 	}
+}
 
 static void setSize(CFTypeRef windowRef, CGFloat width, CGFloat height) {
+	@autoreleasepool {
 		NSWindow* window = (__bridge NSWindow *)windowRef;
 		NSSize size = NSMakeSize(width, height);
 		[window setContentSize:size];
 	}
+}
 
 static void setMinSize(CFTypeRef windowRef, CGFloat width, CGFloat height) {
+	@autoreleasepool {
 		NSWindow* window = (__bridge NSWindow *)windowRef;
 		window.contentMinSize = NSMakeSize(width, height);
 	}
+}
 
 static void setMaxSize(CFTypeRef windowRef, CGFloat width, CGFloat height) {
+	@autoreleasepool {
 		NSWindow* window = (__bridge NSWindow *)windowRef;
 		window.contentMaxSize = NSMakeSize(width, height);
 	}
+}
 
 static void setScreenFrame(CFTypeRef windowRef, CGFloat x, CGFloat y, CGFloat w, CGFloat h) {
+	@autoreleasepool {
 		NSWindow* window = (__bridge NSWindow *)windowRef;
 		NSRect r = NSMakeRect(x, y, w, h);
 		[window setFrame:r display:YES];
 	}
+}
 
 static void hideWindow(CFTypeRef windowRef) {
+	@autoreleasepool {
 		NSWindow* window = (__bridge NSWindow *)windowRef;
 		[window miniaturize:window];
 	}
+}
 
 static void unhideWindow(CFTypeRef windowRef) {
+	@autoreleasepool {
 		NSWindow* window = (__bridge NSWindow *)windowRef;
 		[window deminiaturize:window];
 	}
+}
 
 static NSRect getScreenFrame(CFTypeRef windowRef) {
+	@autoreleasepool {
 		NSWindow* window = (__bridge NSWindow *)windowRef;
 		return [[window screen] frame];
 	}
+}
 
 static void setTitle(CFTypeRef windowRef, CFTypeRef titleRef) {
+	@autoreleasepool {
 		NSWindow *window = (__bridge NSWindow *)windowRef;
 		window.title = (__bridge NSString *)titleRef;
 	}
+}
 
 static int isWindowZoomed(CFTypeRef windowRef) {
+	@autoreleasepool {
 		NSWindow *window = (__bridge NSWindow *)windowRef;
 		return window.zoomed ? 1 : 0;
 	}
+}
 
 static void zoomWindow(CFTypeRef windowRef) {
+	@autoreleasepool {
 		NSWindow *window = (__bridge NSWindow *)windowRef;
 		[window zoom:nil];
 	}
+}
 
 static CFTypeRef layerForView(CFTypeRef viewRef) {
+	@autoreleasepool {
 		NSView *view = (__bridge NSView *)viewRef;
 		return (__bridge CFTypeRef)view.layer;
 	}
+}
 
 static CFTypeRef windowForView(CFTypeRef viewRef) {
+	@autoreleasepool {
 		NSView *view = (__bridge NSView *)viewRef;
 		return (__bridge CFTypeRef)view.window;
 	}
+}
 
 static void raiseWindow(CFTypeRef windowRef) {
+	@autoreleasepool {
 		NSRunningApplication *currentApp = [NSRunningApplication currentApplication];
 		if (![currentApp isActive]) {
 			[currentApp activateWithOptions:(NSApplicationActivateAllWindows | NSApplicationActivateIgnoringOtherApps)];
@@ -205,6 +260,7 @@ static void raiseWindow(CFTypeRef windowRef) {
 		NSWindow* window = (__bridge NSWindow *)windowRef;
 		[window makeKeyAndOrderFront:nil];
 	}
+}
 
 static CFTypeRef createInputContext(CFTypeRef clientRef) {
 	@autoreleasepool {
@@ -241,7 +297,7 @@ func init() {
 	runtime.LockOSThread()
 }
 
-// ViewEvent notified the client of changes to the window AppKit handles.
+// ViewEvent notifies the client of changes to the window AppKit handles.
 // The handles are retained until another ViewEvent is sent.
 type ViewEvent struct {
 	// View is a CFTypeRef for the NSView for the window.

app/os_macos.m

@@ -254,6 +254,7 @@ void gio_showCursor() {
 // some cursors are not public, this tries to use a private cursor
 // and uses fallback when the use of private cursor fails.
 void gio_trySetPrivateCursor(SEL cursorName, NSCursor* fallback) {
+	@autoreleasepool {
 		if ([NSCursor respondsToSelector:cursorName]) {
 			id object = [NSCursor performSelector:cursorName];
 			if ([object isKindOfClass:[NSCursor class]]) {
@@ -263,6 +264,7 @@ void gio_trySetPrivateCursor(SEL cursorName, NSCursor* fallback) {
 		}
 		[fallback set];
 	}
+}
 
 void gio_setCursor(NSUInteger curID) {
 	@autoreleasepool {
@@ -401,9 +403,11 @@ CFTypeRef gio_createView(void) {
 }
 
 void gio_viewSetHandle(CFTypeRef viewRef, uintptr_t handle) {
+	@autoreleasepool {
 		GioView *v = (__bridge GioView *)viewRef;
 		v.handle = handle;
 	}
+}
 
 @implementation GioAppDelegate
 - (void)applicationDidFinishLaunching:(NSNotification *)aNotification {