From 57dee8e61a92dbdeb194965ad80670603f34deb9 Mon Sep 17 00:00:00 2001 From: Elias Naur Date: Wed, 3 Mar 2021 11:15:13 +0100 Subject: [PATCH] cmd/gogio: bump Wine timeout for window movement The Windows tests on builds.sr.ht are still flaky: TestEndToEnd/Windows: e2e_test.go:130: retrying after 400ms TestEndToEnd/Windows: e2e_test.go:130: retrying after 800ms TestEndToEnd/Windows: e2e_test.go:130: retrying after 1.6s TestEndToEnd/Windows: e2e_test.go:130: retrying after 2s TestEndToEnd/Windows: e2e_test.go:130: last error: encountered 6 color mismatches: 5,5 got 0xffffffffffff, want 0xffff00000000 395,5 got 0xffffffffffff, want 0xffff00000000 5,305 got 0xffff00000000, want 0x000000000000 395,305 got 0xffff00000000, want 0x000000000000 405,305 got 0xffffffffffff, want 0xffff00000000 795,305 got 0xffffffffffff, want 0xffff00000000 TestEndToEnd/Windows: e2e_test.go:130: hit timeout of 4s after 6 tries Bump the window movement delay in the hope that it helps. Signed-off-by: Elias Naur --- cmd/gogio/windows_test.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/cmd/gogio/windows_test.go b/cmd/gogio/windows_test.go index 02e8df47..996b5114 100644 --- a/cmd/gogio/windows_test.go +++ b/cmd/gogio/windows_test.go @@ -136,9 +136,9 @@ func (d *WineTestDriver) Start(path string) { // We can't tell if the windowmove operation worked until we take a // screenshot, because the getwindowgeometry op reports the 0x0 // coordinates even if the window wasn't moved properly. - // A sleep of ~20ms seems to be enough on an idle laptop. Use 10x that. + // A sleep of ~20ms seems to be enough on an idle laptop. Use 20x that. // TODO(mvdan): revisit this, when you have a spare three hours. - time.Sleep(200 * time.Millisecond) + time.Sleep(400 * time.Millisecond) id := d.xdotool("search", "--sync", "--onlyvisible", "--name", "Gio") d.xdotool("windowmove", "--sync", id, 0, 0) }