joejulian/gio
1
0
Fork 1
mirror of https://git.sr.ht/~eliasnaur/gio synced 2026-07-07 10:25:37 +00:00
Code Issues Packages Projects Releases Wiki Activity

layout: add resize helpers for constraints

Browse Source 
This commit adds two helper methods to layout.Contraints that make it easier to
manipulate the constraints while keeping their invariants. In particular, code
manually manipulating constraints usually fails to correctly ensure that the
max does not become smaller than the min, the min does not exceed the max, and
that no value goes below zero.

It's quite a few lines to check these invariants yourself in every custom layout,
so I think it makes sense to offer helpers for this.

Signed-off-by: Chris Waldon <christopher.waldon.dev@gmail.com>
This commit is contained in:
Chris Waldon
2023-05-02 12:49:48 -04:00
committed by Elias Naur
parent 0e5ec18a82
commit 59695984e5
2 changed files with 96 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
layout/layout_test.go
+66
View File
@@ -76,3 +76,69 @@ func TestDirection(t *testing.T) {
})
}
}
func TestConstraints(t *testing.T) {
type testcase struct {
name string
in Constraints
subMax image.Point
addMin image.Point
expected Constraints
}
for _, tc := range []testcase{
{
name: "no-op",
in: Constraints{Max: image.Pt(100, 100)},
expected: Constraints{Max: image.Pt(100, 100)},
},
{
name: "shrink max",
in: Constraints{Max: image.Pt(100, 100)},
subMax: image.Pt(25, 25),
expected: Constraints{Max: image.Pt(75, 75)},
},
{
name: "shrink max below min",
in: Constraints{Max: image.Pt(100, 100), Min: image.Pt(50, 50)},
subMax: image.Pt(75, 75),
expected: Constraints{Max: image.Pt(25, 25), Min: image.Pt(25, 25)},
},
{
name: "shrink max below zero",
in: Constraints{Max: image.Pt(100, 100), Min: image.Pt(50, 50)},
subMax: image.Pt(125, 125),
expected: Constraints{Max: image.Pt(0, 0), Min: image.Pt(0, 0)},
},
{
name: "enlarge min",
in: Constraints{Max: image.Pt(100, 100)},
addMin: image.Pt(25, 25),
expected: Constraints{Max: image.Pt(100, 100), Min: image.Pt(25, 25)},
},
{
name: "enlarge min beyond max",
in: Constraints{Max: image.Pt(100, 100)},
addMin: image.Pt(125, 125),
expected: Constraints{Max: image.Pt(100, 100), Min: image.Pt(100, 100)},
},
{
name: "decrease min below zero",
in: Constraints{Max: image.Pt(100, 100), Min: image.Pt(50, 50)},
addMin: image.Pt(-125, -125),
expected: Constraints{Max: image.Pt(100, 100), Min: image.Pt(0, 0)},
},
} {
t.Run(tc.name, func(t *testing.T) {
start := tc.in
if tc.subMax != (image.Point{}) {
start = start.SubMax(tc.subMax)
}
if tc.addMin != (image.Point{}) {
start = start.AddMin(tc.addMin)
}
if start != tc.expected {
t.Errorf("expected %#+v, got %#+v", tc.expected, start)
}
})
}
}