mirror of
https://git.sr.ht/~eliasnaur/gio
synced 2026-07-01 07:35:40 +00:00
layout: don't allow overlapping Flex and Stack layouts
Overlapping layouts such as
outer := layout.Flex{}
inner := layout.Stack{}
child := inner.Rigid(gtx, ...)
outerChild := outer.Rigid(gtx, func() {
inner.Layout(gtx, child)
})
outer.Layout(gtx, outerChild)
runs but result in a wrong layout.
This change use empty StackOps to ensure that the Stack and Flex
child layout methods are called in the same scope as their Layout
methods:
outer := layout.Flex{}
inner := layout.Stack{}
outerChild := outer.Rigid(gtx, func() {
child := inner.Rigid(gtx, ...)
inner.Layout(gtx, child)
})
outer.Layout(gtx, outerChild)
Signed-off-by: Elias Naur <mail@eliasnaur.com>
This commit is contained in:
+15
-3
@@ -16,6 +16,10 @@ type Stack struct {
|
||||
Alignment Direction
|
||||
|
||||
maxSZ image.Point
|
||||
// Use an empty StackOp for tracking whether Rigid, Flex
|
||||
// is called in the same layout scope as Layout.
|
||||
begun bool
|
||||
stack op.StackOp
|
||||
}
|
||||
|
||||
// StackChild is the layout result of a call to End.
|
||||
@@ -34,7 +38,7 @@ func (s *Stack) Rigid(gtx *Context, w Widget) StackChild {
|
||||
m.Record(gtx.Ops)
|
||||
dims := ctxLayout(gtx, cs, w)
|
||||
m.Stop()
|
||||
s.expand(dims)
|
||||
s.expand(gtx.Ops, dims)
|
||||
return StackChild{m, dims}
|
||||
}
|
||||
|
||||
@@ -48,11 +52,15 @@ func (s *Stack) Expand(gtx *Context, w Widget) StackChild {
|
||||
}
|
||||
dims := ctxLayout(gtx, cs, w)
|
||||
m.Stop()
|
||||
s.expand(dims)
|
||||
s.expand(gtx.Ops, dims)
|
||||
return StackChild{m, dims}
|
||||
}
|
||||
|
||||
func (s *Stack) expand(dims Dimensions) {
|
||||
func (s *Stack) expand(ops *op.Ops, dims Dimensions) {
|
||||
if !s.begun {
|
||||
s.stack.Push(ops)
|
||||
s.begun = true
|
||||
}
|
||||
if w := dims.Size.X; w > s.maxSZ.X {
|
||||
s.maxSZ.X = w
|
||||
}
|
||||
@@ -64,8 +72,12 @@ func (s *Stack) expand(dims Dimensions) {
|
||||
// Layout a list of children. The order of the children determines their laid
|
||||
// out order.
|
||||
func (s *Stack) Layout(gtx *Context, children ...StackChild) {
|
||||
if len(children) > 0 {
|
||||
s.stack.Pop()
|
||||
}
|
||||
maxSZ := gtx.Constraints.Constrain(s.maxSZ)
|
||||
s.maxSZ = image.Point{}
|
||||
s.begun = false
|
||||
var baseline int
|
||||
for _, ch := range children {
|
||||
sz := ch.dims.Size
|
||||
|
||||
Reference in New Issue
Block a user