joejulian/gio
1
0
Fork 1
mirror of https://git.sr.ht/~eliasnaur/gio synced 2026-07-06 01:45:36 +00:00
Code Issues Packages Projects Releases Wiki Activity

ui/app: (wasm) use JS allocated buffer for invalidateFramebuffer

Browse Source 
syscall/js.TypedArrayOf is going away in Go 1.13. Avoid it for
invalidateFramebuffer by using a buffer managed by JS.

Signed-off-by: Elias Naur <mail@eliasnaur.com>
This commit is contained in:
Elias Naur
2019-05-23 09:41:54 +02:00
parent bc481ea784
commit 7b13da7299
1 changed files with 7 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files
ui/app/internal/gl/gl_js.go
+7 -13
View File
@@ -11,11 +11,12 @@ type Functions struct {
Ctx js.Value Ctx js.Value
EXT_disjoint_timer_query js.Value EXT_disjoint_timer_query js.Value
EXT_disjoint_timer_query_webgl2 js.Value EXT_disjoint_timer_query_webgl2 js.Value
int32Buf js.Value
} }
var ( var (
uint8Array = js.Global().Get("Uint8Array") uint8Array = js.Global().Get("Uint8Array")
int32Array = js.Global().Get("Int32Array")
) )
func (f *Functions) Init() { func (f *Functions) Init() {
@@ -228,7 +229,11 @@ func (f *Functions) GetUniformLocation(p Program, name string) Uniform {
func (f *Functions) InvalidateFramebuffer(target, attachment Enum) { func (f *Functions) InvalidateFramebuffer(target, attachment Enum) {
fn := f.Ctx.Get("invalidateFramebuffer") fn := f.Ctx.Get("invalidateFramebuffer")
if fn != js.Undefined() { if fn != js.Undefined() {
f.Ctx.Call("invalidateFramebuffer", int(target), int32ArrayOf([]int32{int32(attachment)})) if f.int32Buf == (js.Value{}) {
f.int32Buf = js.Global().Get("Int32Array").New(1)
}
f.int32Buf.SetIndex(0, int32(attachment))
f.Ctx.Call("invalidateFramebuffer", int(target), f.int32Buf)
} }
} }
func (f *Functions) LinkProgram(p Program) { func (f *Functions) LinkProgram(p Program) {
@@ -305,17 +310,6 @@ func paramVal(v js.Value) int {
// decides to grow memory. // decides to grow memory.
// TODO: The workaround is not enough: https://github.com/golang/go/issues/31980. // TODO: The workaround is not enough: https://github.com/golang/go/issues/31980.
func int32ArrayOf(data []int32) js.Value {
if len(data) == 0 {
return js.Null()
}
var a js.Value
a = int32Array.New(len(data))
s := js.TypedArrayOf(data)
a.Call("set", s)
s.Release()
return a
}
func byteArrayOf(data []byte) js.Value { func byteArrayOf(data []byte) js.Value {
if len(data) == 0 { if len(data) == 0 {
return js.Null() return js.Null()