joejulian/gio
1
0
Fork 1
mirror of https://git.sr.ht/~eliasnaur/gio synced 2026-07-07 18:35:34 +00:00
Code Issues Packages Projects Releases Wiki Activity

gpu: [compute] clear viewport through glClear, not through compute

Browse Source 
The performance difference is negligible, but is useful when the compute
pipeline can skip rendering to empty tiles.

Signed-off-by: Elias Naur <mail@eliasnaur.com>
This commit is contained in:
Elias Naur
2021-04-22 10:26:10 +02:00
parent 89ab5ebf4f
commit 938e51f111
1 changed files with 8 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files
gpu/compute.go
+8 -10
View File
@@ -375,6 +375,11 @@ func (g *compute) Frame() error {
mat := g.timers.materials mat := g.timers.materials
mat.begin() mat.begin()
g.ctx.BindFramebuffer(defFBO)
if g.collector.clear {
g.collector.clear = false
g.ctx.Clear(g.collector.clearColor.Float32())
}
if err := g.uploadImages(); err != nil { if err := g.uploadImages(); err != nil {
return err return err
} }
@@ -402,7 +407,6 @@ func (g *compute) Frame() error {
blit = blit.Round(q) blit = blit.Round(q)
t.profile = fmt.Sprintf("ft:%7s mat: %7s et:%7s tat:%7s pct:%7s bbt:%7s ct:%7s k4t:%7s blit:%7s", ft, mat, et, tat, pct, bbt, ct, k4t, blit) t.profile = fmt.Sprintf("ft:%7s mat: %7s et:%7s tat:%7s pct:%7s bbt:%7s ct:%7s k4t:%7s blit:%7s", ft, mat, et, tat, pct, bbt, ct, k4t, blit)
} }
g.collector.clear = false
return nil return nil
} }
@@ -417,11 +421,9 @@ func (g *compute) Profile() string {
func (g *compute) blitOutput(viewport image.Point) { func (g *compute) blitOutput(viewport image.Point) {
t := g.timers.blit t := g.timers.blit
t.begin() t.begin()
if !g.collector.clear { g.ctx.BlendFunc(driver.BlendFactorOne, driver.BlendFactorOneMinusSrcAlpha)
g.ctx.BlendFunc(driver.BlendFactorOne, driver.BlendFactorOneMinusSrcAlpha) g.ctx.SetBlend(true)
g.ctx.SetBlend(true) defer g.ctx.SetBlend(false)
defer g.ctx.SetBlend(false)
}
g.ctx.Viewport(0, 0, viewport.X, viewport.Y) g.ctx.Viewport(0, 0, viewport.X, viewport.Y)
g.ctx.BindTexture(0, g.output.image) g.ctx.BindTexture(0, g.output.image)
g.ctx.BindProgram(g.output.blitProg) g.ctx.BindProgram(g.output.blitProg)
@@ -1195,10 +1197,6 @@ func (c *collector) collect(root *op.Ops, trans f32.Affine2D, viewport image.Poi
func (c *collector) encode(viewport image.Point, enc *encoder, texOps *[]textureOp) { func (c *collector) encode(viewport image.Point, enc *encoder, texOps *[]textureOp) {
fview := f32.Rectangle{Max: layout.FPt(viewport)} fview := f32.Rectangle{Max: layout.FPt(viewport)}
fillMode := scene.FillModeNonzero fillMode := scene.FillModeNonzero
if c.clear {
enc.rect(fview)
enc.fillColor(f32color.NRGBAToRGBA(c.clearColor.SRGB()))
}
for _, op := range c.paintOps { for _, op := range c.paintOps {
// Fill in clip bounds, which the shaders expect to be the union // Fill in clip bounds, which the shaders expect to be the union
// of all affected bounds. // of all affected bounds.