From 99d97d2ef501804be4666d605c4ff7c39d03724f Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Daniel=20Mart=C3=AD?= Date: Mon, 25 Nov 2019 00:02:33 +0000 Subject: [PATCH] cmd/gogio: remove an unnecessary wait in the js e2e test MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit We already wait for the app to render itself via the "frame ready" stdout prints. Waiting for the canvas to be ready isn't really necessary anymore. It helped us while we had to rely on sleeps, but that's no longer the case. Signed-off-by: Daniel Martí --- cmd/gogio/js_test.go | 6 ------ 1 file changed, 6 deletions(-) diff --git a/cmd/gogio/js_test.go b/cmd/gogio/js_test.go index f01fd6fa..0929aa03 100644 --- a/cmd/gogio/js_test.go +++ b/cmd/gogio/js_test.go @@ -128,12 +128,6 @@ func (d *JSTestDriver) Start(t_ *testing.T, path string, width, height int) { d.t.Fatal(err) } - if err := chromedp.Run(ctx, - chromedp.WaitReady("canvas", chromedp.ByQuery), - ); err != nil { - d.t.Fatal(err) - } - // Wait for the gio app to render. <-d.frameNotifs }