From b420fdf096e0d24590c36c059d167fccc7ad6e26 Mon Sep 17 00:00:00 2001 From: Elias Naur Date: Thu, 18 Feb 2021 08:46:03 +0100 Subject: [PATCH] cmd/gogio: remove obsolete headless chrome workaround The two listed issues are fixed, and the builders pass with the workaround removed. Signed-off-by: Elias Naur --- cmd/gogio/js_test.go | 16 ---------------- 1 file changed, 16 deletions(-) diff --git a/cmd/gogio/js_test.go b/cmd/gogio/js_test.go index 8cb567ea..85848946 100644 --- a/cmd/gogio/js_test.go +++ b/cmd/gogio/js_test.go @@ -38,22 +38,6 @@ func (d *JSTestDriver) Start(path string) { // Second, start Chrome. opts := append(chromedp.DefaultExecAllocatorOptions[:], chromedp.Flag("headless", *headless), - - // The default would be use-gl=desktop when there's a GPU we can - // use, falling back to use-gl=swiftshader otherwise or when we - // are running in headless mode. Swiftshader allows full WebGL - // support with just a CPU. - // - // Unfortunately, many Linux distros like Arch and Alpine - // package Chromium without Swiftshader, so we can't rely on the - // defaults above. use-gl=egl works on any machine with a GPU, - // even if we run Chrome in headless mode, which is OK for now. - // - // TODO(mvdan): remove all of this once these issues are fixed: - // - // https://bugs.archlinux.org/task/64307 - // https://gitlab.alpinelinux.org/alpine/aports/issues/10920 - chromedp.Flag("use-gl", "egl"), ) actx, cancel := chromedp.NewExecAllocator(context.Background(), opts...)