joejulian/gio
1
0
Fork 1
mirror of https://git.sr.ht/~eliasnaur/gio synced 2026-07-05 01:15:35 +00:00
Code Issues Packages Projects Releases Wiki Activity

io/semantic: avoid unnecessary pointer indirection

Browse Source 
Putting a string in an interface value has to (normally) heap allocate
the string header and string. However, putting the address of a local
string variable in an interface value has the same effect, as this
causes the local variable to escape to the heap.

Signed-off-by: Dominik Honnef <dominik@honnef.co>
This commit is contained in:
Dominik Honnef
2023-04-11 03:56:23 +02:00
committed by Elias Naur
parent 6937a5dd1f
commit b6e0376ad2
2 changed files with 6 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files
io/router/router.go
+4 -4
View File
@@ -538,11 +538,11 @@ func (q *Router) collect() {
// Semantic ops. // Semantic ops.
case ops.TypeSemanticLabel: case ops.TypeSemanticLabel:
lbl := encOp.Refs[0].(*string) lbl := encOp.Refs[0].(string)
pc.semanticLabel(*lbl) pc.semanticLabel(lbl)
case ops.TypeSemanticDesc: case ops.TypeSemanticDesc:
desc := encOp.Refs[0].(*string) desc := encOp.Refs[0].(string)
pc.semanticDesc(*desc) pc.semanticDesc(desc)
case ops.TypeSemanticClass: case ops.TypeSemanticClass:
class := semantic.ClassOp(encOp.Data[1]) class := semantic.ClassOp(encOp.Data[1])
pc.semanticClass(class) pc.semanticClass(class)
io/semantic/semantic.go
+2 -4
View File
@@ -40,14 +40,12 @@ type SelectedOp bool
type DisabledOp bool type DisabledOp bool
func (l LabelOp) Add(o *op.Ops) { func (l LabelOp) Add(o *op.Ops) {
s := string(l) data := ops.Write1(&o.Internal, ops.TypeSemanticLabelLen, string(l))
data := ops.Write1(&o.Internal, ops.TypeSemanticLabelLen, &s)
data[0] = byte(ops.TypeSemanticLabel) data[0] = byte(ops.TypeSemanticLabel)
} }
func (d DescriptionOp) Add(o *op.Ops) { func (d DescriptionOp) Add(o *op.Ops) {
s := string(d) data := ops.Write1(&o.Internal, ops.TypeSemanticDescLen, string(d))
data := ops.Write1(&o.Internal, ops.TypeSemanticDescLen, &s)
data[0] = byte(ops.TypeSemanticDesc) data[0] = byte(ops.TypeSemanticDesc)
} }