joejulian/gio
1
0
Fork 1
mirror of https://git.sr.ht/~eliasnaur/gio synced 2026-07-01 07:35:40 +00:00
Code Issues Packages Projects Releases Wiki Activity

gpu/internal/opengl,internal/gl: avoid glBufferSubData after glBufferData

Browse Source 
On my Fedora Intel GPU, issuing a glBufferSubData immediately after a
glBufferData with no data may leave the buffer cleared.

Signed-off-by: Elias Naur <mail@eliasnaur.com>
This commit is contained in:
Elias Naur
2021-08-25 13:20:01 +02:00
parent b90e80f03e
commit b9ede6d735
5 changed files with 27 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files
gpu/internal/opengl/opengl.go
+5 -5
View File
@@ -716,7 +716,7 @@ func (b *Backend) NewBuffer(typ driver.BufferBinding, size int) (driver.Buffer,
}
firstBinding := firstBufferType(typ)
b.glstate.bindBuffer(b.funcs, firstBinding, buf.obj)
b.funcs.BufferData(firstBinding, size, gl.DYNAMIC_DRAW)
b.funcs.BufferData(firstBinding, size, gl.DYNAMIC_DRAW, nil)
}
return buf, nil
}
@@ -727,8 +727,7 @@ func (b *Backend) NewImmutableBuffer(typ driver.BufferBinding, data []byte) (dri
buf := &buffer{backend: b, obj: obj, typ: typ, size: len(data), hasBuffer: true}
firstBinding := firstBufferType(typ)
b.glstate.bindBuffer(b.funcs, firstBinding, buf.obj)
b.funcs.BufferData(firstBinding, len(data), gl.STATIC_DRAW)
buf.Upload(data)
b.funcs.BufferData(firstBinding, len(data), gl.STATIC_DRAW, data)
buf.immutable = true
if err := glErr(b.funcs); err != nil {
buf.Release()
@@ -1090,9 +1089,10 @@ func (b *buffer) Upload(data []byte) {
// the iOS GL implementation doesn't recognize when BufferSubData
// clears the entire buffer. Tell it and avoid GPU stalls.
// See also https://github.com/godotengine/godot/issues/23956.
b.backend.funcs.BufferData(firstBinding, b.size, gl.DYNAMIC_DRAW)
b.backend.funcs.BufferData(firstBinding, b.size, gl.DYNAMIC_DRAW, data)
} else {
b.backend.funcs.BufferSubData(firstBinding, 0, data)
}
b.backend.funcs.BufferSubData(firstBinding, 0, data)
}
}
gpu/internal/opengl/srgb.go
+1 -2
View File
@@ -72,8 +72,7 @@ func (s *SRGBFBO) Blit() {
-1, -1, 0, 0,
+1, -1, 1, 0,
})
s.c.BufferData(gl.ARRAY_BUFFER, len(coords), gl.STATIC_DRAW)
s.c.BufferSubData(gl.ARRAY_BUFFER, 0, coords)
s.c.BufferData(gl.ARRAY_BUFFER, len(coords), gl.STATIC_DRAW, coords)
s.blitted = true
}
s.state.useProgram(s.c, s.prog)