diff --git a/widget/editor_test.go b/widget/editor_test.go index e19828c8..b341dc3d 100644 --- a/widget/editor_test.go +++ b/widget/editor_test.go @@ -139,7 +139,7 @@ func TestEditorReadOnly(t *testing.T) { // Type some new characters. gtx.Ops.Reset() gtx.Queue = &testQueue{events: []event.Event{key.EditEvent{Range: key.Range{Start: cStart2, End: cEnd2}, Text: "something else"}}} - e.Layout(gtx, cache, font, fontSize, op.CallOp{}, op.CallOp{}) + e.Update(gtx) textContent2 := e.Text() if textContent2 != textContent { t.Errorf("readonly editor modified by key.EditEvent") @@ -174,7 +174,7 @@ func TestEditorReadOnly(t *testing.T) { Position: layout.FPt(dims.Size).Mul(.5), }, }} - e.Layout(gtx, cache, font, fontSize, op.CallOp{}, op.CallOp{}) + e.Update(gtx) cStart3, cEnd3 := e.Selection() if cStart3 == cStart2 || cEnd3 == cEnd2 { t.Errorf("expected mouse interaction to change selection.") @@ -285,44 +285,10 @@ func TestEditor(t *testing.T) { e.MoveCaret(-3, -3) assertCaret(t, e, 1, 1, len("æbc\na")) e.text.Mask = '*' - e.Layout(gtx, cache, font, fontSize, op.CallOp{}, op.CallOp{}) + e.Update(gtx) assertCaret(t, e, 1, 1, len("æbc\na")) e.MoveCaret(-3, -3) assertCaret(t, e, 0, 2, len("æb")) - /* - NOTE(whereswaldon): it isn't possible to check the raw glyph data - like this anymore. How should we handle this? - e.Mask = '\U0001F92B' - e.Layout(gtx, cache, font, fontSize, op.CallOp{},op.CallOp{}) - e.moveEnd(selectionClear) - assertCaret(t, e, 0, 3, len("æbc")) - - // When a password mask is applied, it should replace all visible glyphs - spaces := 0 - for _, r := range textSample { - if unicode.IsSpace(r) { - spaces++ - } - } - nonSpaces := len([]rune(textSample)) - spaces - glyphCounts := make(map[int]int) - // This loop assumes a single-run text, which we know is safe here. - for _, line := range e.lines { - for _, glyph := range line.Runs[0].Glyphs { - glyphCounts[int(glyph.ID)]++ - } - } - if len(glyphCounts) > 2 { - t.Errorf("masked text contained glyphs other than mask and whitespace") - } - - for gid, count := range glyphCounts { - if count != spaces && count != nonSpaces { - t.Errorf("glyph with id %d occurred %d times, expected either %d or %d", gid, count, spaces, nonSpaces) - } - } - - */ // Test that moveLine applies x offsets from previous moves. e.SetText("long line\nshort") e.SetCaret(0, 0) @@ -680,11 +646,8 @@ func TestEditorMoveWord(t *testing.T) { Constraints: layout.Exact(image.Pt(100, 100)), Locale: english, } - cache := text.NewShaper(text.NoSystemFonts(), text.WithCollection(gofont.Collection())) - fontSize := unit.Sp(10) - font := font.Font{} e.SetText(t) - e.Layout(gtx, cache, font, fontSize, op.CallOp{}, op.CallOp{}) + e.Update(gtx) return e } for ii, tt := range tests { @@ -785,11 +748,8 @@ func TestEditorInsert(t *testing.T) { Constraints: layout.Exact(image.Pt(100, 100)), Locale: english, } - cache := text.NewShaper(text.NoSystemFonts(), text.WithCollection(gofont.Collection())) - fontSize := unit.Sp(10) - font := font.Font{} e.SetText(t) - e.Layout(gtx, cache, font, fontSize, op.CallOp{}, op.CallOp{}) + e.Update(gtx) return e } for ii, tt := range tests { @@ -875,11 +835,8 @@ func TestEditorDeleteWord(t *testing.T) { Constraints: layout.Exact(image.Pt(100, 100)), Locale: english, } - cache := text.NewShaper(text.NoSystemFonts(), text.WithCollection(gofont.Collection())) - fontSize := unit.Sp(10) - font := font.Font{} e.SetText(t) - e.Layout(gtx, cache, font, fontSize, op.CallOp{}, op.CallOp{}) + e.Update(gtx) return e } for ii, tt := range tests {