From ef3e94e7a7580f5874c182de7a16f7890021f7bb Mon Sep 17 00:00:00 2001
From: Elias Naur <mail@eliasnaur.com>
Date: Wed, 19 Feb 2020 20:28:17 +0100
Subject: [PATCH] gpu: add NewBuffer and Buffer.Upload for creating mutable
 buffers

We're going to need them for shader uniform buffer storage.

Signed-off-by: Elias Naur <mail@eliasnaur.com>
---
 gpu/backend.go    |  2 ++
 gpu/gl/backend.go | 52 +++++++++++++++++++++++++++++++++--------------
 2 files changed, 39 insertions(+), 15 deletions(-)

diff --git a/gpu/backend.go b/gpu/backend.go
index d9866201..f75c5ee4 100644
--- a/gpu/backend.go
+++ b/gpu/backend.go
@@ -23,6 +23,7 @@ type Backend interface {
 	NilTexture() Texture
 	NewFramebuffer() Framebuffer
 	NewImmutableBuffer(typ BufferType, data []byte) Buffer
+	NewBuffer(typ BufferType, size int) Buffer
 	NewProgram(vertexShader, fragmentShader ShaderSources) (Program, error)
 	NewInputLayout(vertexShader ShaderSources, layout []InputDesc) (InputLayout, error)
 
@@ -118,6 +119,7 @@ type Buffer interface {
 	BindVertex(stride, offset int)
 	BindIndex()
 	Release()
+	Upload(data []byte)
 }
 
 type Framebuffer interface {
diff --git a/gpu/gl/backend.go b/gpu/gl/backend.go
index 227a77ce..d4542536 100644
--- a/gpu/gl/backend.go
+++ b/gpu/gl/backend.go
@@ -60,9 +60,11 @@ type gpuFramebuffer struct {
 }
 
 type gpuBuffer struct {
-	backend *Backend
-	obj     Buffer
-	typ     Enum
+	backend   *Backend
+	obj       Buffer
+	typ       Enum
+	size      int
+	immutable bool
 }
 
 type gpuProgram struct {
@@ -162,20 +164,18 @@ func (b *Backend) NewTexture(minFilter, magFilter gpu.TextureFilter) gpu.Texture
 	return tex
 }
 
+func (b *Backend) NewBuffer(typ gpu.BufferType, size int) gpu.Buffer {
+	obj := b.funcs.CreateBuffer()
+	gltyp := toBufferType(typ)
+	return &gpuBuffer{backend: b, obj: obj, typ: gltyp, size: size}
+}
+
 func (b *Backend) NewImmutableBuffer(typ gpu.BufferType, data []byte) gpu.Buffer {
 	obj := b.funcs.CreateBuffer()
-	var gltyp Enum
-	switch typ {
-	case gpu.BufferTypeVertices:
-		gltyp = ARRAY_BUFFER
-	case gpu.BufferTypeIndices:
-		gltyp = ELEMENT_ARRAY_BUFFER
-	default:
-		panic("unsupported buffer type")
-	}
-	buf := &gpuBuffer{backend: b, obj: obj, typ: gltyp}
-	b.funcs.BindBuffer(gltyp, obj)
-	b.funcs.BufferData(gltyp, data, STATIC_DRAW)
+	gltyp := toBufferType(typ)
+	buf := &gpuBuffer{backend: b, obj: obj, typ: gltyp, size: len(data)}
+	buf.Upload(data)
+	buf.immutable = true
 	return buf
 }
 
@@ -362,6 +362,17 @@ func (p *gpuProgram) Release() {
 	p.backend.funcs.DeleteProgram(p.obj)
 }
 
+func (b *gpuBuffer) Upload(data []byte) {
+	if b.immutable {
+		panic("immutable buffer")
+	}
+	if len(data) > b.size {
+		panic("buffer size overflow")
+	}
+	b.backend.funcs.BindBuffer(b.typ, b.obj)
+	b.backend.funcs.BufferData(b.typ, data, STATIC_DRAW)
+}
+
 func (b *gpuBuffer) Release() {
 	b.backend.funcs.DeleteBuffer(b.obj)
 }
@@ -567,3 +578,14 @@ func hasExtension(exts []string, ext string) bool {
 	}
 	return false
 }
+
+func toBufferType(typ gpu.BufferType) Enum {
+	switch typ {
+	case gpu.BufferTypeVertices:
+		return ARRAY_BUFFER
+	case gpu.BufferTypeIndices:
+		return ELEMENT_ARRAY_BUFFER
+	default:
+		panic("unsupported buffer type")
+	}
+}