Commit Graph

5 Commits

Author SHA1 Message Date
Elias Naur 7d47fe0fc9 ui/internal/ops: go fmt
Signed-off-by: Elias Naur <mail@eliasnaur.com>
2019-08-26 20:35:16 +01:00
Daniel Martí 2542c55e9d all: fix some issues spotted by static analysis
First, vet was upset by two incorrect fmt verbs. One was an extra %x,
when there was just one argument, so remove it. Another was a %p with a
non-pointer. It's a struct, so for now simply use %#v.

Second, staticcheck found some unused or unnecessary bits of code;
remove the obvious ones.

Finally, staticcheck also complained about some error strings which were
capitalized or had periods. Adjust those, which also makes all error
messages more consistent.

Signed-off-by: Daniel Martí <mvdan@mvdan.cc>
2019-08-25 22:41:05 +01:00
Elias Naur a6c262c1e1 ui: expose internal Ops fields as methods
Signed-off-by: Elias Naur <mail@eliasnaur.com>
2019-08-08 15:20:58 +02:00
Elias Naur eaa4efe5af all: add missing licence headers
Signed-off-by: Elias Naur <mail@eliasnaur.com>
2019-08-07 17:21:34 +02:00
Elias Naur b3517a365e ui,internal/ops,internal/opconst: move OpsReader to internal ops package
To avoid import cycles, move the op constants to its own package,
internal/opconst.

Signed-off-by: Elias Naur <mail@eliasnaur.com>
2019-08-07 17:21:26 +02:00