Chris Waldon 4677b72a4c text: fix over-reading on truncated EOF ...

When consuming text from an io.Reader, the shaper could hit an EOF when reading the
text, then still try to check whether it was done by calling ReadByte() followed by
UnreadByte(). The ReadByte() would still return EOF, but the UnreadByte() would then
walk the iterator cursor backwards to the final byte of the text. If and only if the
text was being truncated, this unexpected cursor position could cause the shaper to
conclude that there were additional runes that were truncated, and thus the returned
glyph stream would account for too many runes. This commit provides a test and a fix.

Many thanks to Jack Mordaunt for the excellent bug report leading to this fix.

Signed-off-by: Chris Waldon <christopher.waldon.dev@gmail.com>

2023-05-26 16:34:59 -06:00

..

testdata/fuzz/FuzzLayout

font/{gofont,opentype},text,widget{,/material}: [API] add font fallback and bidi support

2022-12-13 22:06:57 -06:00

gotext_test.go

text: fix 32-bit glyph id packing

2023-04-29 10:00:49 -06:00

gotext.go

font/opentype: [API] support font collection loading

2023-04-18 16:22:48 -06:00

lru_test.go

font/{gofont,opentype},text,widget{,/material}: [API] add font fallback and bidi support

2022-12-13 22:06:57 -06:00

lru.go

font/opentype: [API] support font collection loading

2023-04-18 16:22:48 -06:00

shaper_test.go

text: fix over-reading on truncated EOF

2023-05-26 16:34:59 -06:00

shaper.go

text: fix over-reading on truncated EOF

2023-05-26 16:34:59 -06:00

text.go

font/opentype: [API] support font collection loading

2023-04-18 16:22:48 -06:00