mirror of
https://git.sr.ht/~eliasnaur/gio
synced 2026-07-01 07:35:40 +00:00
d6f5902c5e
chromedp was defaulting to log.Printf, which is not good for tests. The xgb and xgbutil logs were suppressed if -v wasn't given, but they were sent straight to os.Stderr otherwise: === RUN TestX11 === PAUSE TestX11 === CONT TestX11 XGB: conn.go:47: Could not get authority info: EOF XGB: conn.go:48: Trying connection without authority info... --- PASS: TestX11 (0.87s) Instead, direct their loggers to an io.Writer implementation that sends its output to t.Logf: === RUN TestX11 === PAUSE TestX11 === CONT TestX11 TestX11: x11_test.go:187: XGB: conn.go:47: Could not get authority info: EOF TestX11: x11_test.go:187: XGB: conn.go:48: Trying connection without authority info... --- PASS: TestX11 (0.86s) We do end up with duplicate log prefixes, but at least we don't write straight to stderr, which will be a problem as we add more concurrent tests. Signed-off-by: Daniel Martí <mvdan@mvdan.cc>