Fix entry and group navigation workflows

2026-04-01 10:24:57 -07:00
parent 69aa72ee3b
commit b9ecd0ae70
8 changed files with 389 additions and 8 deletions
@@ -44,6 +44,36 @@ func TestVisibleEntriesFollowsCurrentPathWithoutSearch(t *testing.T) {
 	}
 }

+func TestVisibleEntriesIncludesDescendantEntriesAtParentGroup(t *testing.T) {
+	t.Parallel()
+
+	state := State{
+		Session: stubSession{
+			model: vault.Model{
+				Entries: []vault.Entry{
+					{ID: "dynadot", Title: "Dynadot", Path: []string{"Joe", "Internet"}},
+					{ID: "git-server", Title: "Git Server", Path: []string{"Joe", "Internet"}},
+					{ID: "ha-codex", Title: "Home Assistant (Codex)", Path: []string{"Joe", "Home Assistant"}},
+				},
+			},
+		},
+		CurrentPath: []string{"Joe"},
+	}
+
+	got, err := state.VisibleEntries()
+	if err != nil {
+		t.Fatalf("VisibleEntries() error = %v", err)
+	}
+
+	titles := make([]string, 0, len(got))
+	for _, entry := range got {
+		titles = append(titles, entry.Title)
+	}
+	if !slices.Equal(titles, []string{"Dynadot", "Git Server", "Home Assistant (Codex)"}) {
+		t.Fatalf("visible titles = %v, want descendant entries from Joe", titles)
+	}
+}
+
 func TestPendingApprovalsReturnsManagerRequests(t *testing.T) {
 	t.Parallel()

@@ -160,6 +190,41 @@ func TestVisibleEntriesUsesGlobalSearchWhenQueryPresent(t *testing.T) {
 	}
 }

+func TestVisibleEntriesReturnsDescendantsAfterClearingSearch(t *testing.T) {
+	t.Parallel()
+
+	state := State{
+		Session: stubSession{
+			model: vault.Model{
+				Entries: []vault.Entry{
+					{ID: "dynadot", Title: "Dynadot", Path: []string{"Joe", "Internet"}},
+					{ID: "git-server", Title: "Git Server", URL: "https://git.julianfamily.org", Path: []string{"Joe", "Internet"}},
+					{ID: "ha-codex", Title: "Home Assistant (Codex)", URL: "https://lights.julianfamily.org", Path: []string{"Joe", "Home Assistant"}},
+				},
+			},
+		},
+		CurrentPath: []string{"Joe"},
+		SearchQuery: "missing",
+	}
+
+	got, err := state.VisibleEntries()
+	if err != nil {
+		t.Fatalf("VisibleEntries() with search error = %v", err)
+	}
+	if len(got) != 0 {
+		t.Fatalf("VisibleEntries() with missing search = %#v, want empty", got)
+	}
+
+	state.SearchQuery = ""
+	got, err = state.VisibleEntries()
+	if err != nil {
+		t.Fatalf("VisibleEntries() after clearing search error = %v", err)
+	}
+	if len(got) != 3 {
+		t.Fatalf("len(VisibleEntries()) after clearing search = %d, want 3 descendant entries", len(got))
+	}
+}
+
 func TestVisibleEntriesUsesTemplateSection(t *testing.T) {
 	t.Parallel()

@@ -1150,6 +1215,27 @@ func TestCreateGroupPersistsGroupAndMarksDirty(t *testing.T) {
 	}
 }

+func TestCreateGroupSupportsNestedGroupPath(t *testing.T) {
+	t.Parallel()
+
+	session := &mutableStubSession{model: vault.Model{}}
+	state := State{
+		Session:     session,
+		CurrentPath: []string{"Root"},
+	}
+
+	if err := state.CreateGroup("Infrastructure / Prod"); err != nil {
+		t.Fatalf("CreateGroup() error = %v", err)
+	}
+
+	if got := session.model.ChildGroups([]string{"Root"}); !slices.Equal(got, []string{"Infrastructure"}) {
+		t.Fatalf("ChildGroups(Root) = %v, want [Infrastructure]", got)
+	}
+	if got := session.model.ChildGroups([]string{"Root", "Infrastructure"}); !slices.Equal(got, []string{"Prod"}) {
+		t.Fatalf("ChildGroups(Root/Infrastructure) = %v, want [Prod]", got)
+	}
+}
+
 func TestRenameCurrentGroupUpdatesPathAndMarksDirty(t *testing.T) {
 	t.Parallel()

@@ -1234,6 +1320,37 @@ func TestMoveSelectedEntryPersistsPathChangeAndMarksDirty(t *testing.T) {
 	}
 }

+func TestMoveCurrentGroupMovesHierarchyAndMarksDirty(t *testing.T) {
+	t.Parallel()
+
+	model := vault.Model{
+		Entries: []vault.Entry{
+			{ID: "git-server", Title: "Git Server", Path: []string{"Root", "Internet"}},
+		},
+	}
+	model.CreateGroup([]string{"Root", "Internet"}, "Infrastructure")
+
+	session := &mutableStubSession{model: model}
+	state := State{
+		Session:     session,
+		CurrentPath: []string{"Root", "Internet"},
+	}
+
+	if err := state.MoveCurrentGroup([]string{"Root", "Joe"}); err != nil {
+		t.Fatalf("MoveCurrentGroup() error = %v", err)
+	}
+
+	if !slices.Equal(state.CurrentPath, []string{"Root", "Joe", "Internet"}) {
+		t.Fatalf("CurrentPath = %v, want [Root Joe Internet]", state.CurrentPath)
+	}
+	if got := session.model.EntriesInPath([]string{"Root", "Joe", "Internet"}); len(got) != 1 || got[0].ID != "git-server" {
+		t.Fatalf("EntriesInPath(Root/Joe/Internet) = %#v, want moved entry", got)
+	}
+	if !state.Dirty {
+		t.Fatal("Dirty = false, want true after MoveCurrentGroup")
+	}
+}
+
 func TestAddAttachmentToSelectedEntryPersistsAndMarksDirty(t *testing.T) {
 	t.Parallel()