app: lock explicitly before refreshing contexts

Signed-off-by: Joe Julian <me@joejulian.name>

app/gl_ios.go

@@ -115,9 +115,6 @@ func (c *context) Unlock() {
 }
 
 func (c *context) Refresh() error {
-	if C.gio_makeCurrent(c.ctx) == 0 {
-		return errors.New("[EAGLContext setCurrentContext] failed")
-	}
 	if !c.init {
 		c.init = true
 		c.frameBuffer = c.c.CreateFramebuffer()

app/gl_macos.go

@@ -111,8 +111,6 @@ func (c *glContext) Unlock() {
 }
 
 func (c *glContext) Refresh() error {
-	c.Lock()
-	defer c.Unlock()
 	C.gio_updateContext(c.ctx)
 	return nil
 }

app/os.go

@@ -165,6 +165,8 @@ type frameEvent struct {
 	Sync bool
 }
 
+// The caller must hold the context lock while using API, Refresh,
+// RenderTarget, or Present.
 type context interface {
 	API() gpu.API
 	RenderTarget() (gpu.RenderTarget, error)

app/window.go

@@ -149,6 +149,12 @@ func (w *Window) validateAndProcess(size image.Point, sync bool, frame *op.Ops,
 				sync = true
 			}
 		}
+		if w.ctx != nil {
+			if err := w.ctx.Lock(); err != nil {
+				w.destroyGPU()
+				return err
+			}
+		}
 		if sync && w.ctx != nil {
 			if err := w.ctx.Refresh(); err != nil {
 				if errors.Is(err, errOutOfDate) {
@@ -163,12 +169,6 @@ func (w *Window) validateAndProcess(size image.Point, sync bool, frame *op.Ops,
 				return err
 			}
 		}
-		if w.ctx != nil {
-			if err := w.ctx.Lock(); err != nil {
-				w.destroyGPU()
-				return err
-			}
-		}
 		if w.gpu == nil && !w.nocontext {
 			gpu, err := gpu.New(w.ctx.API())
 			if err != nil {